-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
honor leaflet maxNativeZoom #904
Conversation
Just glancing at the patch, did you want to default back to point.z with no lodmap, or default back to the zoom level as the comment states? eg (this._lodMap && this._lodMap[this._getZoomForUrl()]) ?
this._lodMap[this._getZoomForUrl()] : this._getZoomForUrl()
// instead of
(this._lodMap && this._lodMap[this._getZoomForUrl()]) ?
this._lodMap[this._getZoomForUrl()] : tilePoint.z |
good catch! with no lodmap, we should default back to the zoom level. |
I manually hacked this in to our esri-leaflet-src, and it appears to work. |
travis will show green here as soon as #906 is merged and the build is restarted. |
Should this be working now? I am linking to the file shown on the main page for cdn (https://unpkg.com/[email protected]/dist/esri-leaflet-debug.js) but still not getting native zoom respected. Which version of leaflet did you have this working with? |
hi @ahalota! the fix was included in
if you have more information or can provide a demo of your own i'd be happy to take another look. |
Never mind. It was an odd issue in my ArcServer that was not allowing me to access the higher resolution images and turning up transparent tiles instead... |
honor leaflet maxNativeZoom
resolves #743
@patrickarlt was right. i just had to make sure and update the logic down in
createTile()
too.